You have been requested to review the proposed merge of
lp:~henninge/launchpad/devel-bug-666660-poimport-oops into lp:launchpad/devel.
= Bug 666660 =
This bug is about OOPSes being generated for logging messages that are not
severe enough to warrant that. The code deals with the situation nicely and
simply means to leave a notice for statistical purposes. There really is
nothing we could do about the situation that it is reporting, anyway.
== Proposed fix ==
Lower the logging level of the message to INFO because they won't get generate
OOPSes then.
== Test ==
bin/test -vvct potmsgset.txt
== QA ==
Watch the error reports for the poimport script for OOPSes as described in the
bug. They should not appear any more. But this is not really QA'able because of
the sporadic nature of the occurrences.
No lint.
--
https://code.launchpad.net/~henninge/launchpad/devel-bug-666660-poimport-oops/+merge/39653
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~henninge/launchpad/devel-bug-666660-poimport-oops into lp:launchpad/devel.
=== modified file 'lib/lp/translations/doc/potmsgset.txt'
--- lib/lp/translations/doc/potmsgset.txt 2010-10-27 18:30:31 +0000
+++ lib/lp/translations/doc/potmsgset.txt 2010-10-29 18:59:44 +0000
@@ -624,8 +624,6 @@
>>> message_with_one_form = pm_potmsgset.updateTranslation(
... pm_translation, pm_template.owner, ['%d fu'],
... is_imported=False, lock_timestamp=datetime.now(pytz.UTC))
- WARNING:...Translation for POTMsgSet ... into 'zap' matches
- 2 existing translations.
>>> message_with_one_form == message_with_two_forms
True
=== modified file 'lib/lp/translations/model/potmsgset.py'
--- lib/lp/translations/model/potmsgset.py 2010-10-27 18:30:31 +0000
+++ lib/lp/translations/model/potmsgset.py 2010-10-29 18:59:44 +0000
@@ -557,7 +557,7 @@
if len(matches) > 0:
if len(matches) > 1:
- logging.warn(
+ logging.info(
"Translation for POTMsgSet %s into %s "
"matches %s existing translations." % sqlvalues(
self, pofile.language.code, len(matches)))
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
