Review: Approve Hi Jeroen, This change looks great, r=mars.
I think you have one stray if-statement around line 72 of the diff: you can probably collapse that into a straight if/elif instead of nested statements. Looks good! -- https://code.launchpad.net/~jtv/launchpad/bug-611217/+merge/45883 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/launchpad/bug-611217 into lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
