Review: Approve I only have minor suggestions. I was able to follow the logic of the code, but I don't have a good grasp of how these parts of Launchpad (translation templates, source packages, distro series) work together, so I may have missed something. Feel free to ask for another review.
* You have some copy-and-paste comments on lines 398, 405, and 413. * On line 543, the docstring reads like a commit message. you should say what you're actually setting up. You may also want to refactor your calls to getViewBrowser, but that's not a big deal. * User-visible typo on line 753, "Translations are enable" -> "Translations are enabled" -- https://code.launchpad.net/~launchpad/launchpad/translation-sharing-status/+merge/53419 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~launchpad/launchpad/translation-sharing-status into lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
