small notes - not a code review. We already have a 'don't start script' feature that doesn't require editing cron scripts - and *unlike* one based on feature flags, also does not require db access (which is important for db deploys). Please delete that part of your patch, because I am confident we'll have unintended downtime if we have a db based duplicate facility.
Only LOSAs can set feature flags, so setting e.g. verbosity via a feature flag is still a losa interrupt. It may be better than editing cronscripts [or not - I haven't thought about it] : but losa interruptedness is not a differentiating factor. The rest sounds lovely. Cheers, Rob -- https://code.launchpad.net/~jtv/launchpad/bug-735319/+merge/53578 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/launchpad/bug-735319 into lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
