One bit I didn't mention in the MP: this branch changes the behaviour so forms get constructed only when really needed. In my testing, that means that overlay first gets shown and then collapsing happens which is the only bad side effect I could see. I'd be happy to tackle that as well.
Note that I am not providing any new tests which indicates that there's a lot more missing than it may appear from the first glance. I hope to provide better testing in the future branches that yellow team does. -- https://code.launchpad.net/~danilo/launchpad/refactor-overlay-setup/+merge/56146 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~danilo/launchpad/refactor-overlay-setup into lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
