j.c.sackett has proposed merging lp:~jcsackett/launchpad/bug-expiration into lp:launchpad.
Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #760950 in Launchpad itself: "expire-bugtasks.py, ProgrammingError: permission denied for relation distribution" https://bugs.launchpad.net/launchpad/+bug/760950 For more details, see: https://code.launchpad.net/~jcsackett/launchpad/bug-expiration/+merge/58168 Summary ======= A database permission error occurs when the bug-expiring cronscript runs. Scanning security.cfg reveals that there is a duplicate line for public.distribution, which removes UPDATE permissions. Deleting that line allows the script to run as expected. Preimplementation ================= Spoke with Curtis Hovey, who helped explore the problem with the LOSAs. Implementation ============== Removes the duplicate line. Tests ===== This can't be tested in our testrunner, as the problem exists when the security is updated on production, which uses a different mechanism than the testrunner. QA == Have a LOSA run the bug expiration cron job on staging. It should run without errors. Lint ==== = Launchpad lint = Checking for conflicts and issues in changed files. Linting changed files: database/schema/security.cfg ./database/schema/security.cfg 743: Line exceeds 78 characters. 744: Line exceeds 78 characters. 745: Line exceeds 78 characters. 771: Line exceeds 78 characters. 775: Line exceeds 78 characters. 830: Line exceeds 78 characters. 845: Line exceeds 78 characters. 846: Line exceeds 78 characters. 863: Line exceeds 78 characters. 864: Line exceeds 78 characters. 867: Line exceeds 78 characters. 868: Line exceeds 78 characters. 869: Line exceeds 78 characters. 922: Line exceeds 78 characters. 923: Line exceeds 78 characters. 924: Line exceeds 78 characters. 954: Line exceeds 78 characters. 1036: Line exceeds 78 characters. 1046: Line exceeds 78 characters. 1047: Line exceeds 78 characters. Errors are from structure of security file. -- https://code.launchpad.net/~jcsackett/launchpad/bug-expiration/+merge/58168 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/bug-expiration into lp:launchpad.
=== modified file 'database/schema/security.cfg' --- database/schema/security.cfg 2011-04-15 04:56:44 +0000 +++ database/schema/security.cfg 2011-04-18 17:37:19 +0000 @@ -1556,7 +1556,6 @@ public.question = SELECT public.questionbug = SELECT public.questionsubscription = SELECT -public.distribution = SELECT public.distributionsourcepackage = SELECT, INSERT, UPDATE public.distroseries = SELECT public.section = SELECT
_______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
