Martin Pool has proposed merging lp:~mbp/launchpad/778437-sprb-spam into
lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #778437 in Launchpad itself: "Recipe build success sends emails, please
stop doing that"
https://bugs.launchpad.net/launchpad/+bug/778437
For more details, see:
https://code.launchpad.net/~mbp/launchpad/778437-sprb-spam/+merge/60360
bug 778437 complains source package recipe builds sends a lot of mail (>100 a
day to me). It looks like this was done intentionally but perhaps it was a
mistake.
preimpl conversation with jml; thanks
<poolie> should i: (a) just not send mail on successful builds (b) add a flag
(c) waffle
currently waffling between a and b
<jml> a)
no action required => no email.
I think made the call that we should send email initially
I was wrong.
no new lint warnings
this may need test updates; I'm lazily running the current (fairly slow) tests
to see if anything traps.
--
https://code.launchpad.net/~mbp/launchpad/778437-sprb-spam/+merge/60360
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~mbp/launchpad/778437-sprb-spam into lp:launchpad.
=== modified file 'lib/lp/code/model/sourcepackagerecipebuild.py'
--- lib/lp/code/model/sourcepackagerecipebuild.py 2011-05-04 04:10:58 +0000
+++ lib/lp/code/model/sourcepackagerecipebuild.py 2011-05-09 11:02:23 +0000
@@ -346,17 +346,6 @@
except KeyError:
raise NotFoundError(filename)
- def _handleStatus_OK(self, librarian, slave_status, logger):
- """See `IPackageBuild`."""
- d = super(SourcePackageRecipeBuild, self)._handleStatus_OK(
- librarian, slave_status, logger)
-
- def uploaded_build(ignored):
- # Base implementation doesn't notify on success.
- if self.status == BuildStatus.FULLYBUILT:
- self.notify()
- return d.addCallback(uploaded_build)
-
def getUploader(self, changes):
"""See `IPackageBuild`."""
return self.requester
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
