I would decouple the context manager logic from the instance class - something
like
with use_controller(myinstance):
do stuff
This avoids the current trap where doing
with myinstance:
do stuff
in two threads simultaneously would break horribly.
I haven't done a full review, but this stood out to me.
--
https://code.launchpad.net/~mbp/launchpad/mail-scope/+merge/60281
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~mbp/launchpad/mail-scope into lp:launchpad.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
