The proposal to merge lp:~sinzui/launchpad/remote-bugtracker-components-ui-0 into lp:launchpad has been updated.
Description changed to: Implements UI for displaying components registered at a remote bug tracker Launchpad bug: https://bugs.launchpad.net/bugs/617695 Pre-implementation: Bryce This branch cleans up Bryce's branch so that it can be landed. -------------------------------------------------------------------- RULES * Resolve conflicts with devel. * Moved code out the othe deprecated canonical.launchpad path. * Fix failing tests. * Refactor the implementation parts called out in the review that can be implemented in a simpler way. * ADDENDUM: * Register feture flag bugs.bugtracker_components.enabled * Fixed invalid storm find() clauses * Allow users to unset the a component. QA * After cronscripts/update-bugzilla-remote-components.py has run and the feature is enabled: bugs.bugtracker_components.enabled team:launchpad-beta-testers 1 on) explore https://bugs.launchpad.net/bugs/bugtrackers/gnome-bugs * This is a screenshot of the feature. http://people.canonical.com/~curtis/components.png LINT cronscripts/update-bugzilla-remote-components.py lib/canonical/launchpad/interfaces/_schema_circular_imports.py lib/lp/bugs/configure.zcml lib/lp/bugs/browser/bugtracker.py lib/lp/bugs/browser/configure.zcml lib/lp/bugs/browser/tests/test_bugtracker_component.py lib/lp/bugs/browser/widgets/bugtask.py lib/lp/bugs/interfaces/bugtracker.py lib/lp/bugs/model/bugtracker.py lib/lp/bugs/scripts/bzremotecomponentfinder.py lib/lp/bugs/templates/bugtracker-index.pt lib/lp/bugs/templates/bugtracker-portlet-components.pt lib/lp/bugs/tests/test_bugtracker_components.py lib/lp/bugs/tests/test_bzremotecomponentfinder.py lib/lp/services/features/flags.py TEST ./bin/test -vv -t test_bugtracker_component IMPLEMENTATION I registered a feature flag and fixed the layout in the bug tracker template. lib/lp/services/features/flags.py lib/lp/bugs/templates/bugtracker-index.pt Revised the layout of the components. This feature is born in a pathological state; there are too many items listed for a human to read. I made the layout use the full horizontal space, but I would not call this useable yet. lib/lp/bugs/templates/bugtracker-portlet-components.pt I discovered that the storm find clauses in this module were invalid. they where assignment (=) instead or equality (==). I fixed these. lib/lp/bugs/model/bugtracker.py The edit form was missing a cancel link and setting the components dsp to None caused an oops. lib/lp/bugs/browser/bugtracker.py Bryces's work with my fixes from the review. cronscripts/update-bugzilla-remote-components.py lib/canonical/launchpad/interfaces/_schema_circular_imports.py lib/lp/bugs/configure.zcml lib/lp/bugs/browser/configure.zcml lib/lp/bugs/browser/tests/test_bugtracker_component.py lib/lp/bugs/browser/widgets/bugtask.py lib/lp/bugs/interfaces/bugtracker.py lib/lp/bugs/scripts/bzremotecomponentfinder.py lib/lp/bugs/tests/test_bugtracker_components.py lib/lp/bugs/tests/test_bzremotecomponentfinder.py For more details, see: https://code.launchpad.net/~sinzui/launchpad/remote-bugtracker-components-ui-0/+merge/63392 -- https://code.launchpad.net/~sinzui/launchpad/remote-bugtracker-components-ui-0/+merge/63392 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~sinzui/launchpad/remote-bugtracker-components-ui-0 into lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
