hmm, I ran one of the failed tests after doing make schema with your patch +
db-devel merged together, and it played nice.
ERROR:
lp.codehosting.tests.test_bzrutils.TestGetBranchStackedOnURL.testGetBranchStackedOnUrl(RemoteBranchFormat-default)
(subunit.RemotedTestCase) has an interesting failure:
File "/var/launchpad/test/lib/lp/codehosting/tests/test_bzrutils.py", line 77,
in testGetBranchStackedOnUrl
self.make_branch('stacked-on')
File
"/var/launchpad/tmp/eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/tests/__init__.py",
line 2452, in make_branch
repo = self.make_repository(relpath, format=format)
File
"/var/launchpad/tmp/eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/tests/__init__.py",
line 2480, in make_repository
made_control = self.make_bzrdir(relpath, format=format)
File
"/var/launchpad/tmp/eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/tests/per_controldir/__init__.py",
line 74, in make_bzrdir
relpath, format=format)
File
"/var/launchpad/tmp/eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/tests/__init__.py",
line 2462, in make_bzrdir
t.ensure_base()
File
"/var/launchpad/tmp/eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/transport/__init__.py",
line 366, in ensure_base
self.mkdir('.')
File
"/var/launchpad/tmp/eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/transport/remote.py",
line 242, in mkdir
self._serialise_optional_mode(mode))
File
"/var/launchpad/tmp/eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/transport/remote.py",
line 182, in _call2
return self._client.call(method, *args)
File
"/var/launchpad/tmp/eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/smart/client.py",
line 132, in call
result, protocol = self.call_expecting_body(method, *args)
File
"/var/launchpad/tmp/eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/smart/client.py",
line 145, in call_expecting_body
method, args, expect_response_body=True)
File
"/var/launchpad/tmp/eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/smart/client.py",
line 90, in _call_and_read_response
readv_body=readv_body, body_stream=body_stream)
File
"/var/launchpad/tmp/eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/smart/client.py",
line 63, in _send_request
encoder.call(method, *args)
File
"/var/launchpad/tmp/eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/smart/protocol.py",
line 1309, in call
self._write_end()
File
"/var/launchpad/tmp/eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/smart/protocol.py",
line 1133, in _write_end
self.flush()
File
"/var/launchpad/tmp/eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/smart/protocol.py",
line 1099, in flush
self._real_write_func(''.join(self._buf))
File
"/var/launchpad/tmp/eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/smart/medium.py",
line 396, in accept_bytes
self._accept_bytes(bytes)
File
"/var/launchpad/tmp/eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/smart/medium.py",
line 978, in _accept_bytes
self._medium._accept_bytes(bytes)
File
"/var/launchpad/tmp/eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/smart/medium.py",
line 862, in _accept_bytes
osutils.send_all(self._socket, bytes, self._report_activity)
File
"/var/launchpad/tmp/eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/osutils.py",
line 2081, in send_all
report_activity(sent, 'write')
File
"/var/launchpad/tmp/eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/smart/medium.py",
line 176, in _report_activity
ui.ui_factory.report_transport_activity(self, bytes, direction)
File
"/var/launchpad/tmp/eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/lazy_import.py",
line 111, in __getattribute__
_cleanup()
File
"/var/launchpad/tmp/eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/lazy_import.py",
line 100, in _cleanup
del self._factory
AttributeError: _factory
looks like race/glitch with bzrlib.
--
https://code.launchpad.net/~stub/launchpad/bugsummary/+merge/64583
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~stub/launchpad/bugsummary into lp:launchpad/db-devel.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp