The proposal to merge lp:~jtv/launchpad/bug-798521 into lp:launchpad has been
updated.
Description changed to:
= Summary =
This cleans up some technical debt related to the +queue page, in penance for
my first adding to it in a hurry.
== Implementation details ==
Here's a quick run-through of what I changed (a bit of a grab-bag, but it's all
connected):
Added a Storm class for the PackagesetSources linking table, which was
previously hacked into the python ad-hoc.
Batch-fetched any SourcePackageReleases associated with the PackageUploads on
the page.
Batch-fetched any Packagesets associated with the SourcePackages related to
SourcePackageReleases for source uploads.
Extended CompletePackageUpload to be less like a "PackageUpload with some data
pre-fetched" and more like a "view class for PackageUploads."
Moved some small-scale TAL logic into CompletePackageUpload (but not so much as
to split the <table> structure across TAL and python).
Unit-tested CompletePackageUpload.
Modernized the PackagesetSet unit test, replacing its setUp with specific
factory calls.
== Tests ==
{{{
./bin/test -vvc soyuz.browser.tests.test_queue
./bin/test -vvc soyuz.tests.test_packageset
./bin/test -vvc soyuz -t stories
}}}
== Demo and Q/A ==
The +queue page should still work, and be no less efficient. (Hopefully it
will be slightly more efficient).
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/soyuz/browser/tests/test_queue.py
lib/lp/soyuz/templates/distroseries-queue.pt
lib/lp/soyuz/model/packagesetsources.py
lib/lp/soyuz/browser/queue.py
lib/lp/soyuz/interfaces/packageset.py
lib/lp/soyuz/model/packageset.py
lib/lp/soyuz/tests/test_packageset.py
lib/lp/registry/model/distroseriesdifference.py
For more details, see:
https://code.launchpad.net/~jtv/launchpad/bug-798521/+merge/65297
--
https://code.launchpad.net/~jtv/launchpad/bug-798521/+merge/65297
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~jtv/launchpad/bug-798521 into lp:launchpad.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
