Henning Eggers has proposed merging
lp:~henninge/launchpad/devel-sort-sourcedeps-cache into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~henninge/launchpad/devel-sort-sourcedeps-cache/+merge/74119
= Summary =
Finally sourcedeps.cache changes won't be so noisy!
== Implementation details ==
There is an error in the python documentation about the sort_keys
parameter and its default value that made this solution a bit harder
to discover. But in the end it is obvious ... ;-)
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/devscripts/sourcecode.py
utilities/sourcedeps.cache
./lib/devscripts/sourcecode.py
153: E302 expected 2 blank lines, found 3
338: E302 expected 2 blank lines, found 3
--
https://code.launchpad.net/~henninge/launchpad/devel-sort-sourcedeps-cache/+merge/74119
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~henninge/launchpad/devel-sort-sourcedeps-cache into lp:launchpad.
=== modified file 'lib/devscripts/sourcecode.py'
--- lib/devscripts/sourcecode.py 2011-06-07 15:09:14 +0000
+++ lib/devscripts/sourcecode.py 2011-09-05 17:01:31 +0000
@@ -224,7 +224,7 @@
if cache == old_cache:
return
with open(cache_filename, 'wb') as cache_file:
- json.dump(cache, cache_file, indent=4)
+ json.dump(cache, cache_file, indent=4, sort_keys=True)
if not quiet:
print 'Cache updated. Please commit "%s".' % cache_filename
=== modified file 'utilities/sourcedeps.cache'
--- utilities/sourcedeps.cache 2011-09-02 10:28:09 +0000
+++ utilities/sourcedeps.cache 2011-09-05 17:01:31 +0000
@@ -1,70 +1,70 @@
{
- "testresources": [
- 16,
- "[email protected]"
- ],
- "mailman": [
- 976,
- "[email protected]"
- ],
- "cscvs": [
- 432,
- "[email protected]"
- ],
- "pygpgme": [
- 49,
- "[email protected]"
- ],
- "subvertpy": [
- 2046,
- "[email protected]"
- ],
- "python-debian": [
- 186,
- "[email protected]"
- ],
- "pygettextpo": [
- 24,
- "[email protected]"
+ "bzr-builder": [
+ 68,
+ "[email protected]"
],
"bzr-git": [
259,
"[email protected]"
],
- "loggerhead": [
- 456,
- "[email protected]"
- ],
- "bzr-builder": [
- 68,
- "[email protected]"
+ "bzr-hg": [
+ 290,
+ "[email protected]"
],
"bzr-loom": [
50,
"[email protected]"
],
- "old_xmlplus": [
- 4,
- "sinzui-20090526164636-1swugzupwvjgomo4"
+ "bzr-svn": [
+ 2717,
+ "[email protected]"
],
- "lpreview": [
- 23,
- "[email protected]"
+ "cscvs": [
+ 432,
+ "[email protected]"
],
"difftacular": [
6,
"[email protected]"
],
- "bzr-svn": [
- 2717,
- "[email protected]"
- ],
- "bzr-hg": [
- 290,
- "[email protected]"
- ],
"dulwich": [
426,
"[email protected]"
+ ],
+ "loggerhead": [
+ 456,
+ "[email protected]"
+ ],
+ "lpreview": [
+ 23,
+ "[email protected]"
+ ],
+ "mailman": [
+ 976,
+ "[email protected]"
+ ],
+ "old_xmlplus": [
+ 4,
+ "sinzui-20090526164636-1swugzupwvjgomo4"
+ ],
+ "pygettextpo": [
+ 24,
+ "[email protected]"
+ ],
+ "pygpgme": [
+ 49,
+ "[email protected]"
+ ],
+ "python-debian": [
+ 186,
+ "[email protected]"
+ ],
+ "subvertpy": [
+ 2046,
+ "[email protected]"
+ ],
+ "testresources": [
+ 16,
+ "[email protected]"
]
}
\ No newline at end of file
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
