The proposal to merge lp:~rvb/launchpad/sync-greyedout-resolved-841934 into lp:launchpad has been updated.
Description changed to: This branch fixes canRequestSync so that it's not possible to sync resolved differences. I choose to add an explicit check inside canRequestSync (as opposed to fixing isNewerThanParent) because checking the status is quicker than calling apt_pkg.VersionCompare. Drive-by fix: It also removes an additional space that is present on the derivation portlet. = Tests = ./bin/test -vvc test_distroseries test_canRequestSync_returns_False_if_DSD_is_resolved = QA = The resolved DSDs on this page should not be 'syncable' (the checkboxes should be disabled). https://dogfood.launchpad.net/ubuntu/oneiric/+localpackagediffs?field.name_filter=&field.package_type=resolved&field.package_type-empty-marker=1 For more details, see: https://code.launchpad.net/~rvb/launchpad/sync-greyedout-resolved-841934/+merge/74975 -- https://code.launchpad.net/~rvb/launchpad/sync-greyedout-resolved-841934/+merge/74975 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/launchpad/sync-greyedout-resolved-841934 into lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
