ADDENDUM: I saw a comment in one of the tests suggesting that we verify the correct message was sent. I know how to do that, and I suspected that the correct test would prove the setup was wrong. test_mailToHelp is logging in a different user from the one that will be selected by the weak-authentication rules. I correct the test.
ADDENDUM: test_mailToHelpFromUnknownUser was actually testing with a known address because the setup created the address. In Lp's rules, addresses lead to the creation of a user, so the test was somewhat ambiguous. ADDENDUM: The authentication rules were changed about 18 months ago. It is more likely that there will not be a user when there is not a preferred email address, but there are still cases where active users do not have preferred email addresses. The logic to check if the logged in user has a preferred email address must remain. -- https://code.launchpad.net/~sinzui/launchpad/non-active-user-bug-mail/+merge/77004 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~sinzui/launchpad/non-active-user-bug-mail into lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
