I think it would be clearer if self.inherit_id left the value of report[id]
alone::
tmp_id = 'OOPS-%s' % md5hash
if not self.inherit or report.get(id) is None:
report[id] = tmp_id
"return original_id or report['id']" looks like it's meant to return the
canonical oops-id, but when original_id is non-None, won't it be the same as
report['id']?
--
https://code.launchpad.net/~lifeless/python-oops-datedir-repo/0.0.9/+merge/78793
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~lifeless/python-oops-datedir-repo/0.0.9 into lp:python-oops-datedir-repo.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
