The proposal to merge lp:~wallyworld/launchpad/one-bugtask-for-private-bugs-878605 into lp:launchpad has been updated.
Description changed to: == Implementation == Private bugs can only have one bug task. So we add a canAddTask() method to Bug and if a new bug task cannot be added: 1. Do not show Also Affects links on the bug index page (includes changing privacy via portlet) 2. Raise a mail processing error with a suitable message if an "bug affects" email command is sent 3. Do not allow a bug to be nominated 4. Raise an CannotAddBugTask exception in the addTask method But some teams need to be able to still have the old behaviour so we use a feature flag to allow that: disclosure.allow_multipillar_private_bugs.enabled NB The default is the new behaviour. So we need this feature flag on prod before deploying. == Tests == Add new tests: test_bugs_web_service.TestErrorHandling: - test_add_bugtask_to_private_bug_gives_bad_request test_bug_views.TestAlsoAffectsLinks: - test_no_also_affects_links_when_cannot_add_bugtask - test_also_affects_links_when_can_add_bugtask test_commands.AffectsEmailCommandTestCase: - test_execute_bug_cannot_add_task bug.txt: - add to existing doc tests for addTask Update test: test_bug_views.TestBugSecrecyViews: - test_secrecy_view_ajax_render == Lint == Checking for conflicts and issues in changed files. Linting changed files: lib/lp/bugs/configure.zcml lib/lp/bugs/browser/tests/test_bug_views.py lib/lp/bugs/doc/bug.txt lib/lp/bugs/interfaces/bug.py lib/lp/bugs/javascript/bugtask_index.js lib/lp/bugs/mail/commands.py lib/lp/bugs/mail/errortemplates/cannot-add-task.txt lib/lp/bugs/mail/tests/test_commands.py lib/lp/bugs/model/bug.py lib/lp/bugs/templates/bugtasks-and-nominations-table.pt lib/lp/bugs/tests/test_bugs_webservice.py ./lib/lp/bugs/doc/bug.txt 739: want exceeds 78 characters. ./lib/lp/bugs/mail/errortemplates/cannot-add-task.txt 1: Line exceeds 78 characters. ./lib/lp/bugs/mail/tests/test_commands.py 285: local variable 'product' is assigned to but never used For more details, see: https://code.launchpad.net/~wallyworld/launchpad/one-bugtask-for-private-bugs-878605/+merge/79918 -- https://code.launchpad.net/~wallyworld/launchpad/one-bugtask-for-private-bugs-878605/+merge/79918 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/one-bugtask-for-private-bugs-878605 into lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
