You have been requested to review the proposed merge of
lp:~mbp/launchpad/bug-width into lp:launchpad.
For more details, see:
https://code.launchpad.net/~mbp/launchpad/bug-width/+merge/80161
This changes the max-width for typical text in Launchpad so it is allowed to be
up to 80em rather than just 45em. Much Launchpad bug text originates in
terminals that assume about that width, and with this changed Python tracebacks
for example look much more readable. If the window/font are not such as to
allow 80em of text, it wraps properly at a narrower width (tested on oneiric ff
and chrome.)
I think this gives a better tradeoff between on the one hand not wrapping too
early and leaving white space while mangling the text (bug 435905) and also not
having over-long lines on large windows.
Obviously we could do a lot more (actual markup, preserving whitespace, making
the editor consistent with the displayed form, etc) but this is a step forward.
Before: https://launchpadlibrarian.net/83534958/20111024_004.png
After:
https://bugs.launchpad.net/launchpad/+bug/435905/+attachment/2568961/+files/20111024_005.png
--
https://code.launchpad.net/~mbp/launchpad/bug-width/+merge/80161
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~mbp/launchpad/bug-width into lp:launchpad.
=== modified file 'lib/canonical/launchpad/icing/style-3-0.css'
--- lib/canonical/launchpad/icing/style-3-0.css 2011-08-22 17:01:19 +0000
+++ lib/canonical/launchpad/icing/style-3-0.css 2011-10-23 23:40:32 +0000
@@ -170,15 +170,19 @@
width: auto;
margin-bottom: 0.8em;
}
-p, li, dt, dd, blockquote, .narrow, .narrow-listing {
+p, li, dt, dd, blockquote {
+ /* wrap wide enough to be readable on large screens, but not so wide that screen output wraps */
+ max-width: 80em;
+}
+.narrow, .narrow-listing {
/* Wrap the text before the eye gets lost. */
max-width: 45em;
}
.wide * {
- max-width: 60em;
+ max-width: 80em;
}
table.wide {
- width: 60em;
+ width: 80em;
}
pre, code, samp, tt, .console {
font-family: 'UbuntuBeta Mono', 'Ubuntu Mono', monospace;
@@ -802,7 +806,7 @@
textarea {
display: block;
width: 90%;
- max-width: 60em;
+ max-width: 80em;
}
button {
padding:0;
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
