Huw Wilkins has proposed merging lp:~huwshimi/launchpad/style-removal-one into lp:launchpad.
Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~huwshimi/launchpad/style-removal-one/+merge/82096 Removed a bunch of inline "display: none" styles and replaced with the class "hidden". Pretty trivial really. -- https://code.launchpad.net/~huwshimi/launchpad/style-removal-one/+merge/82096 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~huwshimi/launchpad/style-removal-one into lp:launchpad.
=== modified file 'lib/lp/app/templates/launchpad-link.pt' --- lib/lp/app/templates/launchpad-link.pt 2011-05-27 18:01:09 +0000 +++ lib/lp/app/templates/launchpad-link.pt 2011-11-14 05:25:35 +0000 @@ -3,12 +3,12 @@ xmlns:metal="http://xml.zope.org/namespaces/metal"; > <tal:comment condition="nothing"> -The disabled link is invisble since it has display:none, and it +The disabled link is invisble since it has the "hidden" class, and it only appears when devmode is on, so that tests can more easily verify that links are disabled. </tal:comment> <li tal:condition="not: context/enabled" - style="display:none;"> + class="hidden"> <strong tal:attributes="class string:menu-link-${context/name}-disabled;"><tal:link-text replace="structure context/escapedtext">Disabled text</tal:link-text> === modified file 'lib/lp/app/widgets/templates/date.pt' --- lib/lp/app/widgets/templates/date.pt 2009-07-28 22:44:12 +0000 +++ lib/lp/app/widgets/templates/date.pt 2011-11-14 05:25:35 +0000 @@ -8,7 +8,7 @@ value view/formvalue; disabled view/disabled_flag" /> <tal:daterange condition="view/daterange"> - <span style="display:none;" + <span class="hidden" tal:attributes="id string:${view/name}-daterange" tal:content="view/daterange" /> </tal:daterange> === modified file 'lib/lp/app/widgets/templates/datetime.pt' --- lib/lp/app/widgets/templates/datetime.pt 2009-07-28 22:44:12 +0000 +++ lib/lp/app/widgets/templates/datetime.pt 2011-11-14 05:25:35 +0000 @@ -15,7 +15,7 @@ </a></span> </tal:display_zone> <tal:daterange condition="view/daterange"> - <span style="display:none;" + <span class="hidden" tal:attributes="id string:${view/name}-daterange" tal:content="view/daterange" /> </tal:daterange> === modified file 'lib/lp/bugs/browser/bugtask.py' --- lib/lp/bugs/browser/bugtask.py 2011-11-11 18:36:39 +0000 +++ lib/lp/bugs/browser/bugtask.py 2011-11-14 05:25:35 +0000 @@ -3967,12 +3967,12 @@ if self.context.milestone is None: return '' else: - return 'display: none' + return 'hidden' @property def style_for_edit_milestone(self): if self.context.milestone is None: - return 'display: none' + return 'hidden' else: return '' === modified file 'lib/lp/bugs/templates/bugcomment-macros.pt' --- lib/lp/bugs/templates/bugcomment-macros.pt 2011-10-05 15:24:25 +0000 +++ lib/lp/bugs/templates/bugcomment-macros.pt 2011-11-14 05:25:35 +0000 @@ -59,7 +59,7 @@ <td> <span class="sprite arrowRight"> </span> <span tal:replace="num_hidden">42</span> comments hidden - <span id="more-comments-spinner" style="display: none;"> + <span id="more-comments-spinner" class="hidden"> Loading more comments <img src="/@@/spinner" /> </span> === modified file 'lib/lp/bugs/templates/bugnomination-tasks-and-nominations-table-row.pt' --- lib/lp/bugs/templates/bugnomination-tasks-and-nominations-table-row.pt 2009-07-17 17:59:07 +0000 +++ lib/lp/bugs/templates/bugnomination-tasks-and-nominations-table-row.pt 2011-11-14 05:25:35 +0000 @@ -26,7 +26,7 @@ href view/getNominationEditLink">approve/decline</a>) <div tal:attributes="id nomination_form_id" tal:condition="user_is_driver" - style="display: none"> + class="hidden"> <span style="padding-left: 1.5em" tal:content="structure context/@@+edit-form"> Approve/Decline </span> === modified file 'lib/lp/bugs/templates/bugtarget-filebug-search.pt' --- lib/lp/bugs/templates/bugtarget-filebug-search.pt 2011-04-28 12:51:56 +0000 +++ lib/lp/bugs/templates/bugtarget-filebug-search.pt 2011-11-14 05:25:35 +0000 @@ -138,14 +138,14 @@ tal:define="widget nocall:view/widgets/product|nothing" tal:condition="not:widget"> <div tal:condition="context/enable_bugfiling_duplicate_search" - id="filebug-form-container" class="transparent" style="opacity: 0; display: none"> + id="filebug-form-container" class="transparent hidden"> <tal:filebug-form define="launchpad_form_id string:filebug-form"> <metal:display-similar-bugs use-macro="context/@@+filebug-macros/inline-filebug-form" /> </tal:filebug-form> </div> </tal:not_project_group> - <p style="display: none"> + <p class="hidden"> <a id="filebug-base-url" tal:attributes="href view/inline_filebug_base_url"></a> <a id="filebug-form-url" === modified file 'lib/lp/bugs/templates/bugtask-batched-comments.pt' --- lib/lp/bugs/templates/bugtask-batched-comments.pt 2011-08-26 14:56:29 +0000 +++ lib/lp/bugs/templates/bugtask-batched-comments.pt 2011-11-14 05:25:35 +0000 @@ -5,7 +5,7 @@ <tal:comments> <div - style="display: none" + class="hidden" id="next-batch-url" tal:condition="view/has_more_comments_and_activity" tal:content="view/next_batch_url"></div> === modified file 'lib/lp/bugs/templates/bugtask-index.pt' --- lib/lp/bugs/templates/bugtask-index.pt 2011-11-10 10:51:37 +0000 +++ lib/lp/bugs/templates/bugtask-index.pt 2011-11-14 05:25:35 +0000 @@ -155,8 +155,8 @@ tal:attributes="href string:${context/target/fmt:url}/+bugs?field.tag=${tag}">tag</a> </span> <form id="tags-form" style="display: inline"> - <input type="text" id="tag-input" style="display: none; width: 35em;" /> - <img src="/@@/spinner" id="tags-edit-spinner" style="display: none" /> + <input type="text" id="tag-input" class="hidden" style="width: 35em;" /> + <img src="/@@/spinner" id="tags-edit-spinner" class="hidden"/> <a href="+edit" title="Edit tags" id="edit-tags-trigger" class="sprite edit"></a> <script type="text/javascript"> LPS.use('event', 'node', 'lp.bugs.bug_tags_entry', function(Y) { @@ -181,11 +181,11 @@ }); </script> - <button class="lazr-pos lazr-btn yui-ieditor-submit_button" - id="edit-tags-ok" style="display: none" + <button class="lazr-pos lazr-btn yui-ieditor-submit_button hidden" + id="edit-tags-ok" type="button">Ok</button> - <button class="lazr-neg lazr-btn yui-ieditor-cancel_button" - id="edit-tags-cancel" style="display: none" + <button class="lazr-neg lazr-btn yui-ieditor-cancel_button hidden" + id="edit-tags-cancel" type="button">Cancel</button> </form> <a href="/+help/tag-help.html" target="help" class="sprite maybe"> === modified file 'lib/lp/bugs/templates/bugtask-tasks-and-nominations-table-row.pt' --- lib/lp/bugs/templates/bugtask-tasks-and-nominations-table-row.pt 2011-11-04 18:55:42 +0000 +++ lib/lp/bugs/templates/bugtask-tasks-and-nominations-table-row.pt 2011-11-14 05:25:35 +0000 @@ -165,9 +165,8 @@ tal:condition="data/target_has_milestones" style="width: 100%; float: left"> <a tal:condition="view/user_can_edit_milestone" - class="nulltext addicon js-action sprite add" tal:attributes="href data/edit_link; - style view/style_for_add_milestone"> + class string:nulltext addicon js-action sprite add ${view/style_for_add_milestone}"> Target to milestone </a> <a class="value" @@ -175,8 +174,8 @@ tal:content="context/milestone/title | nothing" /> <a tal:condition="view/user_can_edit_milestone" tal:attributes="href data/edit_link" - ><img class="editicon" src="/@@/edit" - tal:attributes="style view/style_for_edit_milestone" + ><img src="/@@/edit" + tal:attributes="class string:editicon ${view/style_for_edit_milestone}" /></a> </div> </td> === modified file 'lib/lp/bugs/templates/official-bug-target-manage-tags.pt' --- lib/lp/bugs/templates/official-bug-target-manage-tags.pt 2011-04-05 16:05:15 +0000 +++ lib/lp/bugs/templates/official-bug-target-manage-tags.pt 2011-11-14 05:25:35 +0000 @@ -30,7 +30,7 @@ }); </script> - <table id="layout-table" class="official-tags-layout-table" style="display:none"> + <table id="layout-table" class="official-tags-layout-table hidden"> <tr> <th>Official tags</th> <th /> === modified file 'lib/lp/code/templates/branch-form-macros.pt' --- lib/lp/code/templates/branch-form-macros.pt 2011-08-25 10:35:17 +0000 +++ lib/lp/code/templates/branch-form-macros.pt 2011-11-14 05:25:35 +0000 @@ -5,7 +5,7 @@ <metal:add-branch define-macro="add-branch-content"> - <div id="branch-unique-name-div" style="display:none"> + <div id="branch-unique-name-div" class="hidden"> The resulting location of the branch will be: <strong><span id="branch-unique-name"></span></strong> (<a href="/+help/register-branch.html" target="help">Do you need to register?</a>) </div> === modified file 'lib/lp/code/templates/branch-import-details.pt' --- lib/lp/code/templates/branch-import-details.pt 2011-09-28 11:30:52 +0000 +++ lib/lp/code/templates/branch-import-details.pt 2011-11-14 05:25:35 +0000 @@ -27,7 +27,7 @@ type="hidden" name="tryagain.actions.tryagain" value="" /> - <a href="javascript:document.tryagain.submit()" style="display: none" id="tryagainlink"> + <a href="javascript:document.tryagain.submit()" class="hidden" id="tryagainlink"> <img src="/@@/retry" /> Try again </a> === modified file 'lib/lp/code/templates/branch-macros.pt' --- lib/lp/code/templates/branch-macros.pt 2011-07-20 03:34:43 +0000 +++ lib/lp/code/templates/branch-macros.pt 2011-11-14 05:25:35 +0000 @@ -159,7 +159,7 @@ </div> <div tal:condition="show_edit|nothing" tal:attributes="id string:specbranch${spec_branch/id}" - style="display: none" + class="hidden" > <dl><dd> </dd></dl> === modified file 'lib/lp/code/templates/branchmergeproposal-vote-summary.pt' --- lib/lp/code/templates/branchmergeproposal-vote-summary.pt 2009-11-14 22:33:56 +0000 +++ lib/lp/code/templates/branchmergeproposal-vote-summary.pt 2011-11-14 05:25:35 +0000 @@ -44,7 +44,7 @@ <dd tal:condition="context/preview_diff" tal:attributes="class string:popup-diff mp-${context/id}"> Diff: <tal:diff replace="structure context/preview_diff/fmt:link"/> - <a class="api-ref" style="display:none" + <a class="api-ref hidden" tal:attributes="href context/preview_diff/fmt:api_url">api</a> </dd> === modified file 'lib/lp/registry/templates/timeline-macros.pt' --- lib/lp/registry/templates/timeline-macros.pt 2010-11-22 23:08:45 +0000 +++ lib/lp/registry/templates/timeline-macros.pt 2011-11-14 05:25:35 +0000 @@ -15,14 +15,14 @@ that causes the TimelineGraph to adjust the height of the iframe to show the full height of the graph as it is zoomed in and out. </tal:comment> - <div id="timeline-loading" style="display: none"> + <div id="timeline-loading" class="hidden"> <img src="/@@/spinner" /> Loading graph... </div> <!-- Opera ignores overflow:hidden for iframe, so use scrolling=no. --> <iframe id="timeline-iframe" name='timeline-iframe' - class="timeline-iframe" - style="display: none; border: 0" + class="timeline-iframe hidden" + style="border: 0" scrolling="no" width="100%" height="216px"></iframe> <script> === modified file 'lib/lp/translations/templates/translation-import-queue-macros.pt' --- lib/lp/translations/templates/translation-import-queue-macros.pt 2010-07-08 14:29:36 +0000 +++ lib/lp/translations/templates/translation-import-queue-macros.pt 2011-11-14 05:25:35 +0000 @@ -97,7 +97,7 @@ <tal:status define="name string:status_${entry/id}" replace="structure view/widgets/?name" /> </noscript> - <span class="status-choice" style="display:none"> + <span class="status-choice hidden"> <span tal:attributes="class string:value ${css_status}" tal:content="entry/status/title"> Needs review</span>
_______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
