(I realise my reply may look like I hadn't read the MP. I had :)). You cover directly some private objects but not e.g. branch merge proposals or their comments as being private (or even hidden). So there is a risk that folk adding this won't cater for privacy in some contexts, in the current implementation. I'd like to see *something* done to reduce or mitigate that.
And there is no (apparent) consideration for personally identifying data (which is a vague concept at best, but consider for instance that a script running in our context can access an email address that a script running from a different site cannot. We also have the trust issue, which really isn't about the code, but about whether we can trust the google plus API code with private data (and this applies to non-private pages because a script can make API calls and access anything you can access). -- https://code.launchpad.net/~mbp/launchpad/798412-plusone/+merge/83449 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mbp/launchpad/798412-plusone into lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
