Hi Graham, Thanks for looking at this branch.
Am 29/11/11 11:52, schrieb Graham Binns: > Review: Needs Information > > Hi Jelmer, > > Thanks for this branch. I don't know enough about buildd to know whether or > not the fact that you haven't added a test is a bad thing or a necessary > evil. Can you enlighten me? We don't have any real tests for this code, although Martin (Pool) has started looking at refactoring it so it can be more easily tested. When we do, we will hopefully also be testing the exact invocation of "bzr dailydeb". A regression of this bug wouldn't be the worst thing in the world, it just means a slightly incorrect debian/changelog file. We've lived with it until now without problems. Cheers, Jelmer -- https://code.launchpad.net/~jelmer/launchpad-buildd/correct-target-distribution/+merge/83580 Your team Launchpad code reviewers is subscribed to branch lp:launchpad-buildd. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
