On Wed, Dec 07, 2011 at 09:56:26AM -0000, Jeroen T. Vermeulen wrote: > Might it be worthwhile to separate the closure nature of > writeOverrides from its functionality? If you had a separate function > that takes all the necessary variables as arguments, it'd be easier to > move that last paragraph out of the loop (still assuming that that > makes sense at all) and it'd be easier to see that writeOverrides > “borrows” some variables from runGerminate.
Good idea. Per our conversation on IRC, I've used functools.partial for this. I also used it in writeGerminateOutput, which IMO this approach notably improves. What do you think? -- https://code.launchpad.net/~cjwatson/launchpad/refactor-cron-germinate/+merge/84624 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/refactor-cron-germinate into lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
