The proposal to merge lp:~sinzui/launchpad/nomminate-driver-permissions-1 into lp:launchpad has been updated.
Description changed to: Allow driver permission checks on source packages. Launchpad bug: https://bugs.launchpad.net/bugs/901332 Pre-implementation: No one SourcePackage does not implement all of the IHasDrivers interface. The personHasDriverRights that is used for permission checks to work with the object is missing. It is not possible to nominate a fix for a source package at the moment because a regression caused to an effort to implement a single consistent set of permission rules in the bugs domain. -------------------------------------------------------------------- RULES * Add personHasDriverRights on SourcePackage, consider using the HasDriversMixin * ADDENDUM: DSP uses HasDriversMixin to implement personHasDriverRights, but permissions are not specified for callsites to use it. QA * Visit https://bugs.qastaging.launchpad.net/ubuntu/oneiric/+source/linux/+bug/861296/+nominate * Verify the page displays (The page will probably say your do not have permission to nominate) * Visit https://bugs.qastaging.launchpad.net/ubuntu/+source/linux/+bug/861296/+nominate * Verify the page displays (The page will probably say your do not have permission to nominate LINT lib/lp/registry/configure.zcml lib/lp/registry/model/sourcepackage.py lib/lp/registry/tests/test_distributionsourcepackage.py lib/lp/registry/tests/test_sourcepackage.py TEST ./bin/test -vvc -t river lp.registry.tests.test_sourcepackage ./bin/test -vvc -t river lp.registry.tests.test_distributionsourcepackage IMPLEMENTATION Added the HasDriversMixin to SourcePackage to complete the implementation of IHasDrivers. lib/lp/registry/model/sourcepackage.py lib/lp/registry/tests/test_sourcepackage.py Added personHasDriverRights to ZCML after I discovered that adding a comparable test for personHasDriverRights did errored even though the methods is defined. lib/lp/registry/configure.zcml lib/lp/registry/tests/test_distributionsourcepackage.py For more details, see: https://code.launchpad.net/~sinzui/launchpad/nomminate-driver-permissions-1/+merge/84850 -- https://code.launchpad.net/~sinzui/launchpad/nomminate-driver-permissions-1/+merge/84850 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~sinzui/launchpad/nomminate-driver-permissions-1 into lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
