Richard Harding has proposed merging lp:~rharding/launchpad/batch_nav_900900
into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #900900 in Launchpad itself: "navigation links are missing from bug
listing bottom if there is only a single batch."
https://bugs.launchpad.net/launchpad/+bug/900900
For more details, see:
https://code.launchpad.net/~rharding/launchpad/batch_nav_900900/+merge/85935
= Summary =
In most lists you might not hit a second page of results, but you have to
scroll and want to see the number of results and the greyed out next/prev
controls.
== Implementation ==
After discussions if we want this global change it was decided yes. We'll just
turn it on for all result sets for now, and perhaps we can investigate some
more intelligent solutions (based on the actual number of results) in the
future.
== QA ==
Check that in any batched ui set that the bottom batch ui is visible. Examples
include:
new buglisting ui
blueprints list
The next/prev controls should still be greyed out and it should match the top
control.
--
https://code.launchpad.net/~rharding/launchpad/batch_nav_900900/+merge/85935
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~rharding/launchpad/batch_nav_900900 into lp:launchpad.
=== modified file 'lib/canonical/launchpad/webapp/batching.py'
--- lib/canonical/launchpad/webapp/batching.py 2011-10-11 14:37:57 +0000
+++ lib/canonical/launchpad/webapp/batching.py 2011-12-15 19:05:40 +0000
@@ -105,17 +105,8 @@
class LowerBatchNavigationView(UpperBatchNavigationView):
- """Only render bottom navigation links if there are multiple batches."""
-
css_class = "lower-batch-nav"
- def render(self):
- if (self.context.currentBatch() and
- (self.context.nextBatchURL() or
- self.context.prevBatchURL())):
- return LaunchpadView.render(self)
- return u""
-
class BatchNavigator(lazr.batchnavigator.BatchNavigator):
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
