Huw Wilkins has proposed merging
lp:~huwshimi/launchpad/order-button-heights-904751 into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #904751 in Launchpad itself: "odd layout of sort order buttons when all
buttons do not fit on one line"
https://bugs.launchpad.net/launchpad/+bug/904751
For more details, see:
https://code.launchpad.net/~huwshimi/launchpad/order-button-heights-904751/+merge/85987
The selected ordering button was a different height to the other ordering
buttons due to the line height on the arrow sprite. This meant that at narrow
browser widths the new row of buttons would get caught on the selected button.
Here's a screenshot of the problem before:
https://launchpadlibrarian.net/87548465/buglisting-1.png and here's a shot of
the fixed buttons: https://launchpadlibrarian.net/87613281/order_rows.png
--
https://code.launchpad.net/~huwshimi/launchpad/order-button-heights-904751/+merge/85987
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~huwshimi/launchpad/order-button-heights-904751 into lp:launchpad.
=== modified file 'lib/lp/app/javascript/ordering/assets/ordering-core.css'
--- lib/lp/app/javascript/ordering/assets/ordering-core.css 2011-12-05 07:00:37 +0000
+++ lib/lp/app/javascript/ordering/assets/ordering-core.css 2011-12-16 04:31:25 +0000
@@ -29,6 +29,7 @@
vertical-align: middle;
margin-left: 2px;
padding-left: 12px;
+ line-height: 14px;
}
.yui3-orderbybar .config-widget {
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
