Review: Approve
Looks good.
An alternative might be, at the top of abort():
if self.alreadyfailed or self._subprocess is None:
return
else:
self.alreadyfailed = True
That also prevents abort() from being called more than once, which may
or may not be desired.
--
https://code.launchpad.net/~jelmer/launchpad-buildd/early-build-abort/+merge/86625
Your team Launchpad code reviewers is subscribed to branch lp:launchpad-buildd.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
