Richard Harding has proposed merging
lp:~rharding/launchpad/back_sort_buttons_907376 into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #907376 in Launchpad itself: "Order By Bar "buttons" do not appear on
page load"
https://bugs.launchpad.net/launchpad/+bug/907376
For more details, see:
https://code.launchpad.net/~rharding/launchpad/back_sort_buttons_907376/+merge/86701
= Summary =
There's a typo in the change that causes a JS exception.
Y.Object.has_key should be Y.Object.hasKey
--
https://code.launchpad.net/~rharding/launchpad/back_sort_buttons_907376/+merge/86701
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~rharding/launchpad/back_sort_buttons_907376 into lp:launchpad.
=== modified file 'lib/lp/bugs/templates/bugtask-macros-tableview.pt'
--- lib/lp/bugs/templates/bugtask-macros-tableview.pt 2011-12-21 15:59:04 +0000
+++ lib/lp/bugs/templates/bugtask-macros-tableview.pt 2011-12-22 13:36:08 +0000
@@ -694,16 +694,9 @@
var model = navigator.get('model');
model.get('history').after(
'change', function(e) {
- // Only update the sort buttons if we've got a valid batch
- // key.
- if (Y.Object.has_key(e.newVal, 'batch_key')) {
- Y.lp.buglisting_utils.update_sort_button_visibility(
- orderby,
- e.newVal
- );
- }
- }
- );
+ Y.lp.buglisting_utils.update_sort_button_visibility(
+ orderby, e.newVal);
+ });
var config_node = orderby.get('config_node');
var list_util = new Y.lp.buglisting_utils.BugListingConfigUtil({
srcNode: config_node,
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
