I'm a bit concerned at those lack of concurrency tests but it's getting rather late here too (sorry about that) so I don't have time to delve deeply into this right now.
I'm also concerned that the change will cause a storm of re-auth requests to queue up if a few rpc methods are called around the same time, so I think that bit of code needs to make queued requests (waiting on the mutex) return quickly somehow. If you don't figure it out before I start tomorrow, let's work on it together when I do. -- https://code.launchpad.net/~jtv/maas/async-cobbler-login/+merge/90282 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/async-cobbler-login into lp:maas. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
