I'm not done with the review yet but FTR here are my preliminary findings: - basic chart functionality works and I must say it looks pretty cool! For those who want a piece of the action even before it's released: grab that branch: bzr branch lp:~huwshimi/maas/dashboard-events kill any other txlongpoll process running on your machine cd dashboard-events && make sampledata run the threading server: /usr/bin/python2.7 bin/maas runserver 0.0.0.0:5240 --settings=maas.demo --threading Point your browser to http://0.0.0.0:5240/ In another console run: ./bin/maas shell → Create some nodes: [Node().save() for n in range(10)] → Change statuses: import random for n in Node.objects.all(): n.status = random.choice([1, 4, 6, 7]) n.save()
- deleting all the nodes creates an JS error: make sampledata from ./bin/maas shell: $ from maasserver.models import * $ MACAddress.objects.all().delete() $ Nodes.objects.all().delete() The error seems to be inside the drawing library (I'm guessing a coordinate calculation went wrong): Unexpected NAN value while analysing the value of attribute r. - The summary is not properly updated when a node is created/removed (the chart itself seems fine). - "0 nodes running without a registered service". you've told me that this is the number of RESERVED nodes… the label is definitely misleading. -- https://code.launchpad.net/~huwshimi/maas/dashboard-events/+merge/98576 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~huwshimi/maas/dashboard-events into lp:maas. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
