Perhaps note in a comment that the test uses an isolated bzr environment, so the whoami setting does not pollute anything?
This looks good to me. If someone would prefer a different way of calling the whoami code (e.g., using bzrlib rather than a system call) it's not me. Thanks, Brad. -- https://code.launchpad.net/~bac/launchpad/bug-981114-2/+merge/103342 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
