Review: Approve code Hi Stuart.
I like your solution. I looked at the bug too and pondered if a try/except would be easier to maintain than a queue. Can you add a comment before the break to explain catching the IndexError is safer than looking at the length because the work is threaded? -- https://code.launchpad.net/~stub/launchpad/garbo/+merge/103430 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
