Review: Approve code* Thanks Aaron, couple questions, but looks good and ok'ing:
- I'm curious why you didn't make the make_question_job into a factory method and use it like the other factory createXXXX methods? - I know it's just in testing, but with make_user_subject_body_headers it'd be great to have either a namedtuple or dictionary coming back. Keeping the right params in the right order is more likely to break. - In the final test can you add a check for some bit of the email to make sure it's the one you're expecting. -- https://code.launchpad.net/~abentley/launchpad/celery-everywhere-9/+merge/103723 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
