Review: Approve code* Thanks for killing doctests, my mortal enemies!
- I wondering if there's reasoning for the differences in the test helpers. Things like createSetContactViaAddEmailView are camel cased, but then there's _assertEmailAndError. Should they all be _ prefixed 'private' methods? - What's the unicode inducing .doc method? (#73) - The test methods should have some comment for use when failing and displaying the error per the test style guide: https://dev.launchpad.net/TestsStyleGuide -- https://code.launchpad.net/~deryck/launchpad/refactor-editemail-doctest-363916/+merge/103718 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
