419     + return isinstance(item, type) and item.__name__ == 
item.__name__.upper()

How safe is this?

424     + return filter(is_enum, (module.__dict__[name] for name in 
module.__all__))

Again I think we prefer list comprehensions these days.
-- 
https://code.launchpad.net/~jtv/maas/jsenums/+merge/104126
Your team Launchpad code reviewers is requested to review the proposed merge of 
lp:~jtv/maas/jsenums into lp:maas.

_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

Reply via email to