Review: Approve Note: Please try to remove one copy, per IRC:
<abentley> rick_h_: Where was this file before now? <rick_h_> abentley: icing/google-analytics/ga.js <abentley> rick_h_: So with this change, do we have it in three places? <rick_h_> abentley: yes, for the moment <rick_h_> we have to support both combo loader/non-combo loader users I guess we could get rid of the copy in the app/js/google-analytics directory, only the .diff file is *required* <abentley> rick_h_: If we can get rid of a copy, that would be good. <rick_h_> abentley: yea, I don't think we'd lose anything. Will do. -- https://code.launchpad.net/~rharding/launchpad/ga_combo/+merge/105219 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
