Review: Needs Information code
Thank you for this branch.
The wrapping on lines 138 and 171 looks odd.
I do not think the change to retractTeamMembership() in person.py is correct. I
think the change should be in teammmebership.py, possibly in setStatus() or in
a private function as we handle team participation. Consider the case where the
team admin is reviewing membership:
https://qastaging.launchpad.net/~registry/+members
We want to remove canonical-bazaar from ~ registry because the teams members
are now Lp members. The edit page is acting directly on the TeamMembership
object. I think it is just changing status. Users can change status over the
API. I think we need to review this case to be certain retractTeamMembership()
is the centeral place for this change.
--
https://code.launchpad.net/~wallyworld/launchpad/revoke-membership-delete-subscriptions-996882/+merge/105264
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
