-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12-05-15 09:06 AM, Richard Harding wrote: > - should the needs_init be moved to the top of the file? I can't > find anything that enforces it, but I find usual practice is to > have vars setting like that at the top.
I think you mean needs_zcml, since needs_init was a class variable and the patch removed it. I'm fine with moving needs_zcml to the top, but since it's only used by ensure_zcml, I'd move that to the top also. > - Just a curiosity question, what's the u in the new get(ujob_id)? "Universal". Because it's used with a UniversalJobSource. > - What's the long term plan for the run_missing_read and other > jobs? It seems that as people add new jobs they'll need to make > sure to drop in here and extend this to check for their own items? > Are we only worried that certain jobs will drop into this state of > ready but no longer scheduled? If it's something that's a rare test > case is there some place to document this for future jobs that come > along? It would be nice if job sources could automatically register themselves with run_missing_ready at class definition time, but that doesn't fit the way we've been defining job subclasses. We should change the way we define job subclasses anyway, but I don't know if that will make this easier or harder. We can document this at https://dev.launchpad.net/CeleryJobs We could detect cases where users failed to update run_missing_ready by comparing the jobs.celery.enabled_classes feature flag to the list used by run_missing_ready. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk+yWOYACgkQ0F+nu1YWqI0ZzQCfUArmM50CC1dmAWyfyFrhKVqk fJkAn1X7ZVjEtcD7hZO1WKnTNaxJF2zf =7xYr -----END PGP SIGNATURE----- -- https://code.launchpad.net/~abentley/launchpad/sync-pending-jobs/+merge/105715 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
