Brad Crittenden has proposed merging lp:~bac/launchpad/bug-987444 into lp:launchpad.
Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #987444 in Launchpad itself: "RabbitMQLayer intermittently (and very rarely) does not start in parallel tests" https://bugs.launchpad.net/launchpad/+bug/987444 For more details, see: https://code.launchpad.net/~bac/launchpad/bug-987444/+merge/105862 = Summary = Rarely we see the Rabbit MQ layer not start when doing parallel testing. Looking at the rabbitfixture code I see a change made by Martin Pool a while back that has not been released. That fix *should* solve this spurious failure. Martin's fix is here: https://code.launchpad.net/~mbp/rabbitfixture/rabbit-startup/+merge/80285 Looking at line 13 of his diff you see he changes the call from check_running() to is_running(). The former actually raises an exception if the server is not running, which is not what is wanted in the loop where we wait for it to come up. == Proposed fix == Create version 0.3.3 of rabbitfixture which included the desired change plus another that is innocuous. Release rabbitfixture by creating a new milestone on Launchpad, uploading a release tarball as a download file, and pushing the new release to PyPI. Change Launchpad to use the new version. == Demo and Q/A == None = Launchpad lint = Checking for conflicts and issues in changed files. Linting changed files: versions.cfg -- https://code.launchpad.net/~bac/launchpad/bug-987444/+merge/105862 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~bac/launchpad/bug-987444 into lp:launchpad.
=== modified file 'versions.cfg' --- versions.cfg 2012-05-11 14:39:57 +0000 +++ versions.cfg 2012-05-15 17:58:20 +0000 @@ -99,7 +99,7 @@ pytz = 2012c rdflib = 3.1.0 RestrictedPython = 3.5.1 -rabbitfixture = 0.3.2 +rabbitfixture = 0.3.3 roman = 1.4.0 # See http://code.google.com/p/selenium/issues/detail?id=1935 . selenium = 2.0rc3-lp-distribute-fix
_______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
