I have some questions about this branch. Why are test cases that have no layer filtered out? I would think that we have at least a few tests that aren't in a layer (pure unit tests).
The imports for TestCase and filter_tests only need one line so they shouldn't use multi-line imports. FakeTestCase looks like it needs to stretch (it doesn't have any whitespace between methods). The TestFilterTests setUp method probably did something in an earlier edit other than calling the super class' method of the same name, but now that it doesn't, there's no need for it to be defined at all. Instead of "self.assertTrue(layername in results)" you should use assertIn, which generates slightly nicer error messages when the assertion fails. -- https://code.launchpad.net/~bac/launchpad/repeats/+merge/107651 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~bac/launchpad/repeats into lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
