On Mon, Jun 11, 2012 at 5:23 PM, Curtis Hovey <[email protected]> wrote: > Review: Approve code > > This branch is fine to land, but I suspect the removals are incomplete. I see > the TALs 'cache' expression is still registered in > lp/services/memcache/configure.zcml and I think it is best that it be removed > too. > > I think this bug work also fixes/invalidates bug 613780, bug 678320, bug > 729062, bug 760335. While these bugs are about memcached, not the tales, I do > not think anything is really using memcached. memcache_client_factory is the > only function left, and it is only known to our testing layers. You might as > well remove lp.services.memcache.
Thanks for catching the missed registration and identifying more bugs :). I shall fix and link appropriately. There are two garbo jobs using memcache still, and we don't have a sensible replacement yet. I'm inclined to leave it as a useful facility when someone wants schemaless transient storage, which is afterall what memcache excels at. -Rob -- https://code.launchpad.net/~lifeless/launchpad/memcache/+merge/109551 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
