Raphaël Badin has proposed merging lp:~rvb/maas/bug-1014892 into lp:maas. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #1014892 in MAAS: ""make check" doesn't run all tests if one fails" https://bugs.launchpad.net/maas/+bug/1014892
For more details, see: https://code.launchpad.net/~rvb/maas/bug-1014892/+merge/116013 This branch fixes the way the tests are run: now, instead of stopping as soon as one of the test command fails, we run the full test suite no matter what. The trick is that I couldn't used '-' as a prefix to make sure that 'make' would run all the test commands because then the exit code would have been always 0. -- https://code.launchpad.net/~rvb/maas/bug-1014892/+merge/116013 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/maas/bug-1014892 into lp:maas.
=== modified file 'Makefile' --- Makefile 2012-07-12 15:18:10 +0000 +++ Makefile 2012-07-20 15:36:21 +0000 @@ -84,9 +84,11 @@ @touch --no-create bin/py bin/ipy test: build - bin/test.maas - bin/test.maastesting - bin/test.pserv + res=0; \ + if ! bin/test.maas; then res=1; fi; \ + if ! bin/test.maastesting; then res=1; fi; \ + if ! bin/test.pserv; then res=1; fi; \ + if [ $$res -eq 0 ]; then /bin/true; else /bin/false; fi; lint: sources = $(wildcard *.py contrib/*.py) src templates twisted utilities lint: bin/flake8
_______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
