Review: Approve code The code changes look good, but there are a couple of problems with the SQL.
The final UPDATE sets defaultrenewalperiod = 10, but that's a number of days, not an enum. Did you mean to set it to NULL? Additionally, the TeamMembership date_expires fixup should probably be restricted to active memberships, so as not to erase the record of past expiries. -- https://code.launchpad.net/~sinzui/launchpad/remove-automatic-renewal/+merge/117486 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
