Review: Approve

Should the setupBrowserFreshLogin provide the ability to setup based on 
email/etc to skip some test boilerplate? It could use kwargs to allow passing 
an email or name for the getByXXX

#515
Can we add the else just to jump out the if condition returning a value


#517
Should the timing be a constant in the module for easy finding/change/use?
-- 
https://code.launchpad.net/~deryck/launchpad/reauth-for-email-363916/+merge/118612
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

Reply via email to