> The other shared variables that need to be made multiprocessing-safe are: > * recorded_omapi_shared_key > * recorded_leases > * recorded_leases_time > > I don't think it makes sense to make auth.py the place where all these shared > variables come together. To me it would make more sense to have a separate > module to manage this, although of course it could delegate things like the > initialization call to individual modules.
All right, I thought you said during our pre-imp that you thought it was a good idea to protect the secrets quickly and *then* do the same for the other globals… but I can refactor my branch to create a module with all the globals and the utility associated with it. fwiw, I'd rather have this module be in charge of the initialization of the variables as well. -- https://code.launchpad.net/~rvb/maas/share-mem/+merge/119371 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/maas/share-mem into lp:maas. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
