Review: Needs Information code + ui
My head spins thinking about everything that is happening in this branch.
1. Thank you Ian and William. I like this branch. I like the UI. I favour
William's in-line presentation which helps setting up new projects.
2. I think we need to migrate policies for users because
A. When there is no choice, making someone select the only choice is
infuriatingly annoying.
B. Launchpad does not show all the projects a user or team maintains...how
do I find my project's?
C. We cannot remove legacy rules until *every* project is migrated.
D. You maintain more than 1,200 projects and you will have to set the
policies for them.
[/me may be the only person to have actually every looked at
every project ~registry and ~launchpad maintains]
3. The UI implies bugs and branches are configured and the project uses Lp. We
expect this to be the case for commercial projects, but this certainly is not
the case for most projects. Do also have the policies on the bug and branches
configuration pages? Do we explain that configuring the policies will not also
configure the applications? Per point 2, having sensible defaults and migrating
to them addresses some of the problem -- the policies are configured, but will
not be used until the project's bugs and branches apps are configured. Orange
squad want project registration to have sensible defaults, so I think we are
about to collide with them if we need decide users need to visit lots of pages
to get their project to work.
4. I think we want to migrate or hard code distros since there is no choice.
Maintainers should be aware of why Private and Security are shown on the page.
The maintainers can read about the policies on help.lp.net when we update the
wiki.
5. How do we advise commercial project maintainer? The Legacy text does not
explain what the current rules are, and the UI lies in the case of branches. I
know private-bugs does not map to bug-sharing-policy, but
proprietary-may-be-public is similar to the current behaviour. BVP forbidden
does not map given that we have to support anyone pushing a branch now. The BVP
private-only may map to proprietary-only-proprietary option.
I think this branch is fine to land, but I believe we need to remove the legacy
support very soon, maybe before beta.
I also prefer William's UI, so maybe we want William to land his
version...except that I know there is a second branch that I will review next
and it might conflict with William's UI.
--
https://code.launchpad.net/~wallyworld/launchpad/edit-sharing-policies-1036437/+merge/119466
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
