Steve Kowalik has proposed merging lp:~stevenk/launchpad/fix-bug-623281 into
lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #623281 in Launchpad itself: "IBuilder.currentjob should not be a
property"
https://bugs.launchpad.net/launchpad/+bug/623281
For more details, see:
https://code.launchpad.net/~stevenk/launchpad/fix-bug-623281/+merge/119674
The comment before IBuilder.currentjob must of been true at some point, but it
isn't now. The query boils down to "SELECT * FROM BuildQueue WHERE
BuildQueue.builder = <X> ORDER BY BuildQueue.id" which involves an index scan
and should be very quick.
--
https://code.launchpad.net/~stevenk/launchpad/fix-bug-623281/+merge/119674
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~stevenk/launchpad/fix-bug-623281 into lp:launchpad.
=== modified file 'lib/lp/buildmaster/model/builder.py'
--- lib/lp/buildmaster/model/builder.py 2012-06-29 08:40:05 +0000
+++ lib/lp/buildmaster/model/builder.py 2012-08-15 05:59:21 +0000
@@ -501,8 +501,6 @@
"""See IBuilder."""
return self.slave.clean()
- # XXX 2010-08-24 Julian bug=623281
- # This should not be a property! It's masking a complicated query.
@cachedproperty
def currentjob(self):
"""See IBuilder"""
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
