Review: Approve code Colin thanks for doing this change and for performing the analysis that Robert requested. What you've done *seems* reasonable to me, and I agree you've made a terrible query a wee bit terribler.
Thanks for the refactoring and cleaning up some of the code. Based on the scale of the impact I will approve this branch but ask that you seek out Stuart's opinion for possible improvements before landing. -- https://code.launchpad.net/~cjwatson/launchpad/queue-filter-source/+merge/119225 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
