Review: Approve
The code looks good Abel: this is a nice and well tested incremental change.
Unfortunately I don't have a brilliant suggestion for the name of the new
permission.
The tests pass, the new ones and the changed ones. Some comments follow.
286 + def check_permissions(self, expected_permissions, used_permissions,
287 + type_):
It seems that indentation should be fixed here.
343 + def test_set_permissions(self):
344 + expected_get_permissions = {
Maybe you intended expected_set_permissions?
--
https://code.launchpad.net/~adeuring/launchpad/specification-auth-check/+merge/120430
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
