The proposal to merge lp:~jcsackett/launchpad/kill-lazr-1 into lp:launchpad has been updated.
Description changed to: Summary ======= As the first part of migrating lazr to a new lp.ui namespace, this moves the the lazr.base code to lp.ui. Preimp ====== Spoke with Rick Harding Implementation ============== * Moved lib/lp/app/javascript/lazr/lazr.js to lib/lp/app/javascript/ui/ui.js, and updated related paths. * Renamed the lazr.ui namespace to lp.ui and updated callsites. * Renamed lazr.base module to lp.ui-base module, and updated callsites. Tests ===== bin/test -vvc --layer=YUI QA == Make sure javascript is still working across the site. This is a big one. LoC === This removes 5 LoC; truthfully, it's LoC neutral if restricted to meaningful LoC. Lint ==== Checking for conflicts and issues in changed files. Linting changed files: lib/lp/app/javascript/picker/tests/test_personpicker.html lib/lp/registry/javascript/tests/test_distroseriesdifferences_details.html lib/lp/registry/javascript/sharing/tests/test_granteetable.html lib/lp/bugs/javascript/tests/test_bug_picker.html lib/lp/answers/javascript/tests/test_subscribers.html lib/lp/app/javascript/picker/tests/test_picker_patcher.html lib/lp/app/javascript/choiceedit/tests/test_choiceedit.html lib/lp/app/javascript/ui/ui.js lib/lp/bugs/javascript/tests/test_official_bug_tags.html lib/lp/registry/javascript/distroseries/tests/test_widgets.html lib/lp/app/javascript/tests/test_multicheckboxwidget.html lib/lp/app/javascript/formwidgets/tests/test_formwidgets.html lib/lp/app/javascript/picker/assets/skins/sam/picker-skin.css lib/lp/app/javascript/inlineedit/editor.js lib/lp/app/javascript/inlineedit/assets/skins/sam/editor-skin.css lib/lp/code/javascript/tests/test_bugspeclinks.html lib/lp/answers/javascript/tests/test_answercontacts.html lib/lp/app/javascript/activator/activator.js lib/lp/registry/javascript/distroseries/tests/test_differences.html lib/lp/app/javascript/subscribers/tests/test_subscribers_list.html lib/lp/app/javascript/picker/tests/test_picker.js lib/lp/translations/javascript/tests/test_importqueue.html lib/lp/bugs/javascript/bugtask_index.js lib/lp/app/javascript/anim/tests/test_anim.html lib/lp/registry/javascript/sharing/tests/test_granteepicker.html lib/lp/app/javascript/formoverlay/tests/test_formoverlay.html lib/lp/app/javascript/choiceedit/choiceedit.js lib/lp/registry/javascript/distroseries/tests/test_initseries.html lib/lp/bugs/javascript/tests/test_bugtask_delete.html lib/lp/app/javascript/confirmationoverlay/tests/test_confirmationoverlay.html lib/lp/code/javascript/tests/test_branchrevisionexpander.html lib/lp/app/javascript/picker/picker.js lib/lp/registry/javascript/sharing/tests/test_pillarsharingview.html lib/lp/app/javascript/activator/tests/test_activator.html lib/lp/bugs/javascript/tests/test_subscribers.html lib/lp/bugs/javascript/bug_tags_entry.js lib/lp/bugs/javascript/tests/test_information_type_choice.html buildout-templates/bin/combine-css.in lib/lp/app/javascript/picker/tests/test_team.html lib/lp/app/javascript/picker/tests/test_picker.html lib/lp/code/javascript/tests/test_branchmergeproposal.nominate.html lib/lp/bugs/javascript/tests/test_duplicates.html lib/lp/app/javascript/activator/assets/skins/sam/activator-skin.css lib/lp/app/javascript/inlineedit/tests/test_inline_edit.html lib/lp/bugs/javascript/official_bug_tags.js For more details, see: https://code.launchpad.net/~jcsackett/launchpad/kill-lazr-1/+merge/121079 -- https://code.launchpad.net/~jcsackett/launchpad/kill-lazr-1/+merge/121079 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/kill-lazr-1 into lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
