> Just a quick comment in looking over things. It would be best if the banner, > portlet, and the actual change widget all communicated via an event vs direct > calls. The widget should just fire a 'privacy_value_change' event that the > banner and portlet can listen to and respond as required. In this way you're > not tied to having these exact parts in place and code couple possibly be > shared more from bug/code uses. Any data needed can be passed into the event > as misc data.
Yes, agree. The common functionality is factored out into a separate module in this branch. The decoupling using events can happen later though since this branch is large enough already and is simply building on what was there previously. -- https://code.launchpad.net/~wallyworld/launchpad/branch-infotype-portlet2-1040999/+merge/121527 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/branch-infotype-portlet2-1040999 into lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
