Review: Approve code + def _check_and_set_sharing_policy(self, var, enum, kind, allowed_types):
It doesn't actually set the sharing policy. It just prepares for it. 27 + if var != enum.PUBLIC: 28 + if not self.has_current_commercial_subscription: This can be a single if statement now. 208 + return self.makeProduct(skip_sharing_policy=True, **kwargs) Privacy relies on the APs existing, so you can't set skip_sharing_policy unconditionally here. I think it'd be better to have the one or two tests that need it remove the APs themselves, rather than preventing them from being created in the first place. -- https://code.launchpad.net/~stevenk/launchpad/shift-ap-creation/+merge/121985 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
